Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Convenience functions for accessing markers in local and world space #2389

Merged
merged 2 commits into from
May 8, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR adds a few convenience functions and bindings to provide quick access to the nested dictionary structure of marker points in both object local and world space.

How Has This Been Tested

Locally c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 May 8, 2024 15:47
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 8, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/esp/bindings/PhysicsObjectBindings.cpp Outdated Show resolved Hide resolved
src/esp/bindings/PhysicsObjectBindings.cpp Outdated Show resolved Hide resolved
@jturner65 jturner65 merged commit fdd0ab8 into main May 8, 2024
9 of 10 checks passed
@jturner65 jturner65 deleted the MarkerSets_Utils branch May 8, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants